Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for backtrace on run + test #71

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

netromdk
Copy link
Contributor

  • Added a missing type for cargo-process--enable-rust-backtrace
  • Fixed set-rust-backtrace such that if cargo-process--enable-rust-backtrace is set and command is "run" or "test" (before it would check for "cargo run" or "cargo test" while the input didn't contain "cargo"), then it sets cargo-process--rust-backtrace. Additionally, if cargo-process--enable-rust-backtrace is not set then it resets cargo-process--rust-backtrace. Otherwise, it is enabled for the next commands as well even if cargo-process--enable-rust-backtrace is disabled.

I found the bug while testing with this:

(defun msk/cargo-run-backtrace ()
  (interactive)
  (let ((cargo-process--enable-rust-backtrace t))
    (cargo-process-run)))

@netromdk
Copy link
Contributor Author

Any update on this? :)

@kwrooijen kwrooijen merged commit b8856f9 into kwrooijen:master Dec 3, 2018
@kwrooijen
Copy link
Owner

Sorry for the late response, thanks for this!

@netromdk netromdk deleted the fix_backtrace branch December 3, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants