Make rust-mode optional #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not depend on `rust-mode' because only a single function from that package is required by a single function (which in turn is used by a single command). Do this so that users who use `rustic'[-mode] can use `cargo' without having to install `rust-mode' just for that one function. Teach `cargo-process--get-current-test' to use the respective `rustic' function. If neither package installed then make it instruct the user to install either one of them.
|
Very useful change, thanks. I'm sure people will appreciate this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not depend on
rust-modebecause only a single function from thatpackage is required by a single function (which in turn is used by a
single command). Do this so that users who use
rustic[-mode] canuse
cargowithout having to install `rust-mode' just for that onefunction.
Teach
cargo-process--get-current-testto use the respectiverusticfunction. If neither package installed then make it instruct the user
to install either one of them.