Add support for repositoryName named equally to a repositoryUser #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thrown back to the landing page and was thus not able to see the tags of this image. This commit fixes this issue.
|
If this works and has no side effects, can it be merged? I am maintaining a fork based on this fix, but don't wish to just for that ;) |
added 2 commits
April 11, 2016 11:25
FrontSide
force-pushed
the
v2
branch
3 times, most recently
from
086f9ee to
627f99b
Compare
After the tag detail change has been merged in, the changes made before to support accessing repositories that have tha same name as user are not sufficeient anymore. With these chages it is now possible to list the detail tag page of all repositories.
This variable will be used to display the hostname of the docker registry on the tag detail page for the docker pull command. Since as actual host, usually, the docker container 'registry' is defined, 'registry' would also show up in this command even though it's not the actual URL to the docker-registry from which the image can be pulled.
Author
|
Not up to date anymore. Close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an image has the same name as a top level repository, the user got thrown back to the landing page and was thus not able to see the tags of this image. This fixes this issue for me.
For example:
A image stored on the registry at:
private.registry.com:5000/redisis displayed on the frontend as follows:
Clicking this link currently doesn't show the user the image's tags but instead throws the user back to the landing page.