Avoid potential re-entrancy attacks in the donate() method.

kwight · Nov 28, 2021 · 7318064 · 7318064
1 parent 3c9e1f3
commit 7318064
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/contracts/Fundraisers.sol b/contracts/Fundraisers.sol
@@ -157,15 +157,15 @@ contract Fundraisers is Ownable {
             "program is not active"
         );
         Program memory receivingProgram = programs[programId];
-        (bool sent, ) = receivingProgram.charity.call{value: msg.value}("");
-        require(sent, "ether not sent to charity");
         donations.push(
             Donation({
                 doner: msg.sender,
                 programId: programId,
                 amount: msg.value
             })
         );
+        (bool sent, ) = receivingProgram.charity.call{value: msg.value}("");
+        require(sent, "ether not sent to charity");
         emit DonationReceived(
             msg.value,
             receivingProgram.charity,