[change] 'Erubis::Engine.load_file()' to rename temporary file instea…

…d of using flock
kwatch · Mar 20, 2011 · 2c7f043 · 2c7f043
1 parent 94ea249
commit 2c7f043
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/erubis/engine.rb b/lib/erubis/engine.rb
@@ -54,11 +54,9 @@ def self.load_file(filename, properties={})
       else
         input = File.open(filename, 'rb') {|f| f.read }
         engine = self.new(input, properties)
-        File.open(cachename, 'wb') do |f|
-          f.flock(File::LOCK_EX)
-          f.write(engine.src)
-          f.flush()
-        end
+        tmpname = cachename + rand().to_s[1,8]
+        File.open(tmpname, 'wb') {|f| f.write(engine.src) }
+        File.rename(tmpname, cachename)
       end
       engine.src.untaint   # ok?
       return engine