-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[docs]: refine README for dpo updates #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mrhaoxx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the documentation to accurately reflect recent updates regarding DPO (Direct Preference Optimization) fine-tuning capabilities. It ensures that users have up-to-date information on DPO support, correct model references, and clear guidance for training and inference, enhancing the overall usability and accuracy of the project's documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation to include information about the new DPO fine-tuning support. It adds an entry to the main README, creates a new DPO tutorial, and links to it from the kt-sft README. The changes are mostly good, but I've found a couple of minor issues in the new tutorial file (DPO_tutorial.md): a grammatical error and an inconsistent model name in one of the examples. My review includes suggestions to fix these for clarity and correctness.
| For more details about --kt_optimize_rule, please refer to https://github.com/kvcache-ai/ktransformers/blob/main/doc/en/KTransformers-Fine-Tuning_User-Guide.md | ||
| (2)examples/inference/deepseek2_lora_dpo_kt.yaml | ||
| Then, you can use the lora adapter saved in `saves/Kllama_deepseekV2_DPO` for inference the same as the sft training. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this clarification is helpful, the YAML configuration example that follows (starting on line 135) appears to have an inconsistency. The model_name_or_path on line 136 is set to DeepSeek-V2-Lite-Chat, but earlier in this document (lines 64 and 83), this was updated to deepseek-ai/DeepSeek-V2-Lite. Please update line 136 as well for consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
What does this PR do?
Fixes # (issue)
Before submitting