Conversation
Signed-off-by: Schatten <czhengt@qq.com>
bitborne
requested review from
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 23, 2026 14:20
This was referenced Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract the embedded HTTP metadata server's enablement, port, and host into
AdminHttpBootstrapConfig. The loader owns defaults and the existing precedence of flat YAML/JSON keys followed by explicitly supplied CLI flags. No new public keys or grouped configuration schema are introduced; the metadata-cleanup setting remains separate.Validate the effective port before converting it to the server's
uint16_tport type. Values outside0..65535now produce a startup configuration error instead of silently selecting a different port;0remains accepted. This follows the validation and scope lessons from #4275 and advances the internal ownership work in #3809 / #2694. Unlike the older #2256, this PR does not move HTTP server ownership into the HA supervisor or change metadata cleanup behavior.Module
mooncake-transfer-engine)mooncake-store)mooncake-conductor)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
cmake --build build --target http_metadata_server_test mooncake_master -j222 ctest --test-dir build -R '^http_metadata_server_test$' --output-on-failure build/mooncake-store/src/mooncake_master --http_metadata_server_port=-1 build/mooncake-store/src/mooncake_master --http_metadata_server_port=65536 ./scripts/code_format.sh --staged --checkTest results:
http_metadata_server_testpassed 11/11 tests.Checklist
./scripts/code_format.shAI Assistance Disclosure
Codex assisted with the scoped implementation, tests, and review. The human submitter is responsible for reviewing every changed line and defending the change end-to-end.