[Store] Structure ClientMetricConfig environment settings - #3773
Open
bitborne wants to merge 1 commit into
Open
Conversation
Signed-off-by: Schatten <czhengt@qq.com>
bitborne
requested review from
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
August 29, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the staged convergence of
mooncake-storeenvironment configuration for client metrics.MC_STORE_CLIENT_METRIC,MC_STORE_CLIENT_METRIC_INTERVAL, andMC_STORE_CLIENT_METRIC_BANDWIDTHdefinitions underClientMetricEnvironmentVariables.ClientMetricConfig::FromEnvironment()to own environment reads and parsing beforeClientMetricconstruction.PR #1538 also touches client metric environment handling as part of a broad cross-component migration. This PR is intentionally limited to the current grouped environment-definition and configuration-object pattern, without changing existing client metric behavior.
Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
cmake --build build --target client_metric_config_test client_metrics_test -j32 ctest --test-dir build -R '^(client_metric_config_test|client_metrics_test)$' --output-on-failure pre-commit run --files mooncake-common/include/environment_variables.h mooncake-store/include/client_metric.h mooncake-store/src/CMakeLists.txt mooncake-store/src/client_metric.cpp mooncake-store/src/config/client_metric_config.cpp mooncake-store/tests/CMakeLists.txt mooncake-store/tests/client_metric_config_test.cpp mooncake-store/tests/client_metrics_test.cppTest results:
Checklist
./scripts/code_format.shAI Assistance Disclosure
Codex was used to inspect the existing configuration patterns, implement the focused refactor and tests, and run review and verification checks. I reviewed the final diff and can explain the changes end to end.