Skip to content

Comments

Change all macro INTRA_NVLINK to INTRA_NODE_NVLINK#1507

Open
Copilot wants to merge 5 commits intomainfrom
copilot/update-intra-nvlink-macro
Open

Change all macro INTRA_NVLINK to INTRA_NODE_NVLINK#1507
Copilot wants to merge 5 commits intomainfrom
copilot/update-intra-nvlink-macro

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Description

Renames the USE_INTRA_NVLINK build macro to USE_INTRA_NODE_NVLINK and the MC_INTRANODE_NVLINK environment variable to MC_INTRA_NODE_NVLINK for naming consistency with the intranode NVLink transport feature.

Changes:

  • CMake options and compile definitions across mooncake-common, mooncake-integration, and mooncake-transfer-engine
  • Preprocessor guards in C++ source files (multi_transport.cpp, transfer_engine_impl.cpp, example benchmarks)
  • Error messages referencing the compile flag
  • Environment variable name in transfer_engine_impl.cpp changed from MC_INTRANODE_NVLINK to MC_INTRA_NODE_NVLINK
  • Documentation build option references updated to MC_INTRA_NODE_NVLINK

Type of Change

  • Types
    • Bug fix
    • New feature
      • Transfer Engine
      • Mooncake Store
      • Mooncake EP
      • Integration
      • P2P Store
      • Python Wheel
    • Breaking change
    • CI/CD
    • Documentation update
    • Other

How Has This Been Tested?

Verified all occurrences of INTRA_NVLINK and MC_INTRANODE_NVLINK were replaced via repository-wide search. No remaining references to the old macro or environment variable names exist.

Checklist

  • I have performed a self-review of my own code.
  • I have formatted my own code using ./scripts/code_format.sh before submitting.
  • I have updated the documentation.
  • I have added tests to prove my changes are effective.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com>
Copilot AI changed the title [WIP] Update macro INTRA_NVLINK to INTRA_NODE_NVLINK Change all macro INTRA_NVLINK to INTRA_NODE_NVLINK Feb 5, 2026
Copilot AI requested a review from stmatengss February 5, 2026 16:45
@stmatengss stmatengss marked this pull request as ready for review February 6, 2026 11:17
Copy link
Collaborator

@alogfans alogfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ShangmingCai ShangmingCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stmatengss
Copy link
Collaborator

Will it affect the correctness of this PR: https://github.com/sgl-project/sglang/pull/17866/changes#diff-57994369b15ad2dae4060399006d759a7f12b2c36b322ba7424d6ca052cfce4cR26?

No, it's not an environment variable; I want to use the same prefix for both sglang and Mooncake.

@stmatengss stmatengss closed this Feb 9, 2026
@stmatengss stmatengss reopened this Feb 9, 2026
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...integration/transfer_engine/transfer_engine_py.cpp 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@stmatengss
Copy link
Collaborator

@copilot Change all MC_INTRANODE_NVLINK to MC_INTRA_NODE_NVLINK

Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 11, 2026

@copilot Change all MC_INTRANODE_NVLINK to MC_INTRA_NODE_NVLINK

Done in a38833e. Changed all occurrences of MC_INTRANODE_NVLINK to MC_INTRA_NODE_NVLINK in the source code and documentation files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants