Change all macro INTRA_NVLINK to INTRA_NODE_NVLINK#1507
Change all macro INTRA_NVLINK to INTRA_NODE_NVLINK#1507
Conversation
Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com>
ShangmingCai
left a comment
There was a problem hiding this comment.
Will it affect the correctness of this PR: https://github.com/sgl-project/sglang/pull/17866/changes#diff-57994369b15ad2dae4060399006d759a7f12b2c36b322ba7424d6ca052cfce4cR26?
No, it's not an environment variable; I want to use the same prefix for both sglang and Mooncake. |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@copilot Change all |
Co-authored-by: stmatengss <11641725+stmatengss@users.noreply.github.com>
Description
Renames the
USE_INTRA_NVLINKbuild macro toUSE_INTRA_NODE_NVLINKand theMC_INTRANODE_NVLINKenvironment variable toMC_INTRA_NODE_NVLINKfor naming consistency with the intranode NVLink transport feature.Changes:
mooncake-common,mooncake-integration, andmooncake-transfer-enginemulti_transport.cpp,transfer_engine_impl.cpp, example benchmarks)transfer_engine_impl.cppchanged fromMC_INTRANODE_NVLINKtoMC_INTRA_NODE_NVLINKMC_INTRA_NODE_NVLINKType of Change
How Has This Been Tested?
Verified all occurrences of
INTRA_NVLINKandMC_INTRANODE_NVLINKwere replaced via repository-wide search. No remaining references to the old macro or environment variable names exist.Checklist
./scripts/code_format.shbefore submitting.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.