Skip to content

Commit

Permalink
ASoC: Intel: use software node API in SoundWire machines
Browse files Browse the repository at this point in the history
The function device_add_properties() is going to be removed.
Replacing it with software node API equivalents.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Co-developed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210813151116.23931-7-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
plbossart authored and broonie committed Aug 13, 2021
1 parent 8202758 commit e5a292d
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 4 deletions.
14 changes: 12 additions & 2 deletions sound/soc/intel/boards/sof_sdw_rt711.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,22 @@
static int rt711_add_codec_device_props(struct device *sdw_dev)
{
struct property_entry props[MAX_NO_PROPS] = {};
struct fwnode_handle *fwnode;
int ret;

if (!SOF_RT711_JDSRC(sof_sdw_quirk))
return 0;
props[0] = PROPERTY_ENTRY_U32("realtek,jd-src", SOF_RT711_JDSRC(sof_sdw_quirk));

return device_add_properties(sdw_dev, props);
fwnode = fwnode_create_software_node(props, NULL);
if (IS_ERR(fwnode))
return PTR_ERR(fwnode);

ret = device_add_software_node(sdw_dev, to_software_node(fwnode));

fwnode_handle_put(fwnode);

return ret;
}

static const struct snd_soc_dapm_widget rt711_widgets[] = {
Expand Down Expand Up @@ -129,7 +139,7 @@ int sof_sdw_rt711_exit(struct snd_soc_card *card, struct snd_soc_dai_link *dai_l
{
struct mc_private *ctx = snd_soc_card_get_drvdata(card);

device_remove_properties(ctx->headset_codec_dev);
device_remove_software_node(ctx->headset_codec_dev);
put_device(ctx->headset_codec_dev);

return 0;
Expand Down
14 changes: 12 additions & 2 deletions sound/soc/intel/boards/sof_sdw_rt711_sdca.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,23 @@
static int rt711_sdca_add_codec_device_props(struct device *sdw_dev)
{
struct property_entry props[MAX_NO_PROPS] = {};
struct fwnode_handle *fwnode;
int ret;

if (!SOF_RT711_JDSRC(sof_sdw_quirk))
return 0;

props[0] = PROPERTY_ENTRY_U32("realtek,jd-src", SOF_RT711_JDSRC(sof_sdw_quirk));

return device_add_properties(sdw_dev, props);
fwnode = fwnode_create_software_node(props, NULL);
if (IS_ERR(fwnode))
return PTR_ERR(fwnode);

ret = device_add_software_node(sdw_dev, to_software_node(fwnode));

fwnode_handle_put(fwnode);

return ret;
}

static const struct snd_soc_dapm_widget rt711_sdca_widgets[] = {
Expand Down Expand Up @@ -130,7 +140,7 @@ int sof_sdw_rt711_sdca_exit(struct snd_soc_card *card, struct snd_soc_dai_link *
{
struct mc_private *ctx = snd_soc_card_get_drvdata(card);

device_remove_properties(ctx->headset_codec_dev);
device_remove_software_node(ctx->headset_codec_dev);
put_device(ctx->headset_codec_dev);

return 0;
Expand Down

0 comments on commit e5a292d

Please sign in to comment.