-
Notifications
You must be signed in to change notification settings - Fork 17
feat(auth): improve auth events #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6583d9 to
11c9f7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7-dev #746 +/- ##
==========================================
+ Coverage 82.86% 86.01% +3.14%
==========================================
Files 46 46
Lines 2119 2131 +12
Branches 410 410
==========================================
+ Hits 1756 1833 +77
Misses 282 282
+ Partials 81 16 -65 ☔ View full report in Codecov by Sentry. |
etrousset
approved these changes
Sep 18, 2024
QuentinRousselet
approved these changes
Sep 18, 2024
afondard
approved these changes
Sep 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
# [7.12.0](v7.11.3...v7.12.0) (2024-09-18) ### Features * **auth:** improve auth events ([#746](#746)) ([fe7be9d](fe7be9d))
|
🎉 This PR is included in version 7.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add before and after events for login and logout events to replace
loginAttemptandlogoutAttempt(previous events are keep for legacy).So add the follow events:
beforeLogintriggered before login attemptafterLogintriggered after login attempt and work exactly same asloginAttempt(same callback arguments)beforeLogouttriggered before logout attemptafterLogouttriggered after logout attempt and work exactly same aslogoutAttempt(same callback arguments)Other changes
afterLogoutandlogoutAttemptin error caseBoyscout