Add support for the document:deleteFields API action #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
May 13, 2021
scottinet
changed the title
… unexpected token with ESLint
Codecov Report
@@ Coverage Diff @@
## 7-dev #636 +/- ##
=======================================
Coverage 86.15% 86.16%
=======================================
Files 34 34
Lines 1589 1597 +8
Branches 279 281 +2
=======================================
+ Hits 1369 1376 +7
- Misses 162 163 +1
Partials 58 58
Continue to review full report at Codecov.
|
Aschen
approved these changes
May 25, 2021
Leodau
approved these changes
May 27, 2021
| @@ -0,0 +1,7 @@ | |||
| try { | |||
| const response = await kuzzle.document.deleteFields('nyc-open-data', 'yellow-taxi', 'some-id', ['bar'], {source: true}); | |||
There was a problem hiding this comment.
Nit
Suggested change
| const response = await kuzzle.document.deleteFields('nyc-open-data', 'yellow-taxi', 'some-id', ['bar'], {source: true}); | |
| const response = await kuzzle.document.deleteFields('nyc-open-data', 'yellow-taxi', 'some-id', ['bar'], { source: true }); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR add the action
⚠️ Depends on #632
document:deleteFieldsand the associated documentation and tests