- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
Add bulk:updateByQuery and document:mUpsert #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report
 @@            Coverage Diff             @@
##            7-dev     #633      +/-   ##
==========================================
- Coverage   86.15%   85.75%   -0.40%     
==========================================
  Files          34       34              
  Lines        1589     1601      +12     
  Branches      279      282       +3     
==========================================
+ Hits         1369     1373       +4     
- Misses        162      170       +8     
  Partials       58       58              
 Continue to review full report at Codecov. 
 | 
        
          
                doc/7/controllers/bulk/update-by-query/snippets/update-by-query.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just apply the requested changes and this will be good for me 👍
…y.js Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you should add the timeout option from @Shiranuit  PR
| |---------------|-------------------|-------------------------------------------| | ||
| | `index` | <pre>string</pre> | Index name | | ||
| | `collection` | <pre>string</pre> | Collection name | | ||
| | `searchQuery` | <pre>object</pre> | Query to match | | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should match the method parameter name query
# [7.7.1](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.7.1) (2021-05-31) #### Enhancements - [ [#633](#633) ] Add bulk:updateByQuery and document:mUpsert ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
What does this PR do ?
Add
bulk:updateByQueryanddocument:mUpsertapi actions