[HOTFIX] Clear PingTimeout #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 86.54% 86.75% +0.20%
==========================================
Files 33 33
Lines 1501 1502 +1
Branches 262 262
==========================================
+ Hits 1299 1303 +4
+ Misses 149 146 -3
Partials 53 53
Continue to review full report at Codecov.
|
Aschen
approved these changes
Feb 25, 2021
Aschen
suggested changes
Feb 25, 2021
scottinet
suggested changes
Feb 25, 2021
src/protocols/abstract/Realtime.ts
Outdated
| * Called when the client's connection is closed | ||
| */ | ||
| clientDisconnected () { | ||
| clearInterval(this.pingIntervalId); |
There was a problem hiding this comment.
The Realtime object is a generic class that does not know anything about those properties, since they are specific to the websocket protocol
What you can do is to add an overload to these Realtime methods in the WebSocket class, clear the timers there, and then invoke the overloaded methods
jenow
approved these changes
Feb 25, 2021
scottinet
approved these changes
Feb 25, 2021
alexandrebouthinon
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the ping clearTimeout
How should this be manually tested?
...
Other changes
Boyscout