Allows to not send realtime notification on document controller #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #595 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 32 32
Lines 1468 1468
Branches 261 261
=======================================
Hits 1281 1281
Misses 136 136
Partials 51 51
Continue to review full report at Codecov.
|
scottinet
suggested changes
Jan 28, 2021
Comment on lines
37
to
38
| | `silent` | <pre>boolean</pre><br/>(`false`) | If `true`, then Kuzzle will not generate notifications <SinceBadge version="change-me"/> | | ||
| | `retryOnConflict` | <pre>int</pre><br/>(`0`) | The number of times the database layer should retry in case of version conflict | |
There was a problem hiding this comment.
Options are sorted alphabetically:
Suggested change
| | `silent` | <pre>boolean</pre><br/>(`false`) | If `true`, then Kuzzle will not generate notifications <SinceBadge version="change-me"/> | | |
| | `retryOnConflict` | <pre>int</pre><br/>(`0`) | The number of times the database layer should retry in case of version conflict | | |
| | `retryOnConflict` | <pre>int</pre><br/>(`0`) | The number of times the database layer should retry in case of version conflict | | |
| | `silent` | <pre>boolean</pre><br/>(`false`) | If `true`, then Kuzzle will not generate notifications <SinceBadge version="change-me"/> | |
Comment on lines
47
to
50
| | `refresh` | <pre>string</pre><br/>(`""`) | If set to `wait_for`, waits for the change to be reflected for `search` (up to 1s) | | ||
| | `silent` | <pre>boolean</pre><br/>(`false`) | If `true`, then Kuzzle will not generate notifications <SinceBadge version="change-me"/> | | ||
| | `source` | <pre>boolean</pre><br/>(`false`) | If true, returns the updated document inside the response | | ||
| | `lang` | <pre>string</pre> | Specify the query language to use. By default, it's `elasticsearch` but `koncorde` can also be used. <SinceBadge version="7.4.8"/> | |
There was a problem hiding this comment.
sort:
Suggested change
| | `refresh` | <pre>string</pre><br/>(`""`) | If set to `wait_for`, waits for the change to be reflected for `search` (up to 1s) | | |
| | `silent` | <pre>boolean</pre><br/>(`false`) | If `true`, then Kuzzle will not generate notifications <SinceBadge version="change-me"/> | | |
| | `source` | <pre>boolean</pre><br/>(`false`) | If true, returns the updated document inside the response | | |
| | `lang` | <pre>string</pre> | Specify the query language to use. By default, it's `elasticsearch` but `koncorde` can also be used. <SinceBadge version="7.4.8"/> | | |
| | `lang` | <pre>string</pre> | Specify the query language to use. By default, it's `elasticsearch` but `koncorde` can also be used. <SinceBadge version="7.4.8"/> | | |
| | `refresh` | <pre>string</pre><br/>(`""`) | If set to `wait_for`, waits for the change to be reflected for `search` (up to 1s) | | |
| | `silent` | <pre>boolean</pre><br/>(`false`) | If `true`, then Kuzzle will not generate notifications <SinceBadge version="change-me"/> | | |
| | `source` | <pre>boolean</pre><br/>(`false`) | If true, returns the updated document inside the response | |
added 2 commits
January 28, 2021 11:17
scottinet
approved these changes
Jan 29, 2021
xbill82
approved these changes
Jan 29, 2021
Merged
Aschen
added a commit
that referenced
this pull request
Jan 29, 2021
# [7.5.3](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.5.3) (2021-01-29) #### Enhancements - [ [#596](#596) ] Error stacktrace overhaul ([Aschen](https://github.com/Aschen)) - [ [#595](#595) ] Allows to not send realtime notification on document controller ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
kuzzleio/kuzzle#1946