Fix duplicate subscriptions on reconnect #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 96.15% 96.07% -0.09%
==========================================
Files 33 33
Lines 1612 1630 +18
==========================================
+ Hits 1550 1566 +16
- Misses 62 64 +2
Continue to review full report at Codecov.
|
|
Keeping in wip for the time being:
|
benoitvidis
force-pushed
the
kzl-1324-fix-duplicate-subs-on-reconnect
branch
from
3f445cb to
63965b8
Compare
|
Removing wip: The attached gist failure is due to a bug in Kuzzle and addressed here |
scottinet
approved these changes
Aug 8, 2019
scottinet
suggested changes
Aug 8, 2019
|
@scottinet You're right. The fixed behaviours have been there for a while now. I think we can wait for the next release. |
scottinet
approved these changes
Aug 8, 2019
alexandrebouthinon
approved these changes
Aug 9, 2019
Merged
scottinet
added a commit
that referenced
this pull request
Sep 11, 2019
# [6.2.2](https://github.com/kuzzleio/sdk-javascript/releases/tag/6.2.2) (2019-09-11) #### Bug fixes - [ [#437](#437) ] Fix duplicate subscriptions on reconnect ([benoitvidis](https://github.com/benoitvidis)) #### Enhancements - [ [#439](#439) ] Add timeout support to Http protocol ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the jwt expires, all subscriptions are reset. Users need to manually resubscribe on the
tokenExpiredevent.This PR attempts to fix the following situations:
tokenExpiredandautoResubscribeis on and if Kuzzle client gets disconnected and the token expires during the disconnection, when the client is reconnected, the subscriptions are added twice.tokenExpiredcollisions can mess the attached eventsUnhandledRejectionissued by a failing autoresubscribe if the token expired in the meantimeChanges
realtimecontroller cleans up the rooms ondisconnectandnetworkErrorevents to avoid some leaks.tokenExpiredevent is now handled at Kuzzle level anddiscardedevent.