Add bulk:write and bulk:mWrite #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebouthinon
approved these changes
Jul 15, 2019
thomasarbona
approved these changes
Jul 15, 2019
scottinet
suggested changes
Jul 15, 2019
src/controllers/bulk.js
Outdated
|
|
||
| /** | ||
| * Create or replace multiple documents directly into the storage engine. | ||
| * https://docs.kuzzle.io/core/1/api/controllers/bulk/m-write/ |
There was a problem hiding this comment.
(nitpicking) use @link (see above)
benoitvidis
approved these changes
Jul 15, 2019
Co-Authored-By: Sébastien Cottinet <scottinet@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## 6-dev #419 +/- ##
=========================================
+ Coverage 96.3% 96.31% +<.01%
=========================================
Files 32 32
Lines 1517 1521 +4
=========================================
+ Hits 1461 1465 +4
Misses 56 56
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 6-dev #419 +/- ##
=========================================
+ Coverage 96.3% 96.33% +0.02%
=========================================
Files 32 32
Lines 1517 1527 +10
=========================================
+ Hits 1461 1471 +10
Misses 56 56
Continue to review full report at Codecov.
|
scottinet
reviewed
Jul 16, 2019
| | \_id | <pre>string</pre> | ID of the newly created document | | ||
| | \_version | <pre>number</pre> | Version of the document in the persistent data storage | | ||
| | \_source | <pre>object</pre> | Created document | ||
| | `\_id` | <pre>string</pre> | ID of the newly created document | |
There was a problem hiding this comment.
Shouldn't you get rid of those backslashes now that these names are between backquotes?
scottinet
approved these changes
Jul 17, 2019
Merged
scottinet
added a commit
that referenced
this pull request
Jul 31, 2019
# [6.2.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/6.2.0) (2019-07-31) #### Bug fixes - [ [#428](#428) ] Properly handle boolean flags in HTTP querystrings ([scottinet](https://github.com/scottinet)) - [ [#427](#427) ] Solve promise+event+memory leaks when the network fails ([scottinet](https://github.com/scottinet)) - [ [#424](#424) ] Prevent pending request leak when disconnect the SDK ([Aschen](https://github.com/Aschen)) - [ [#422](#422) ] Fix bug when decoding JWT in browser ([Aschen](https://github.com/Aschen)) - [ [#420](#420) ] Fix http protocol unresolved promise on connection error ([Aschen](https://github.com/Aschen)) #### New features - [ [#419](#419) ] Add bulk:write and bulk:mWrite ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#421](#421) ] Get api routes from server:publicApi ([Aschen](https://github.com/Aschen)) - [ [#423](#423) ] Emit queryError event on malformed request ([Aschen](https://github.com/Aschen)) - [ [#417](#417) ] Security controller documentation ([benoitvidis](https://github.com/benoitvidis)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
bulk:writeandbulk:mWritesupport.I'm not sure if it's an enhancement or a new feature (it was a new feature in Kuzzle)