[KZL-996] Save Kuzzle API routes in a json file #370
Conversation
Codecov Report
@@ Coverage Diff @@
## 6-dev #370 +/- ##
=========================================
+ Coverage 96.65% 96.7% +0.05%
=========================================
Files 29 29
Lines 1434 1427 -7
=========================================
- Hits 1386 1380 -6
+ Misses 48 47 -1
Continue to review full report at Codecov.
|
| return Promise.resolve(); | ||
| } | ||
|
|
||
| return this._sendHttpRequest('GET', '/') |
There was a problem hiding this comment.
This is not used anymore, you should remove this call because it may throw an error if the anonymous user does not have the server:info right
There was a problem hiding this comment.
Anonymous can use the HTTP protocol since this function will not reject in case of permissions issue. You'll still get a response from the server (with 403 status code yes but a response). This will rejects only in case of network or JSON parsing issue. 🙂
|
@scottinet : I put this PR on WIP. After quick talk with @Aschen, it sounds cool to have a new route in Kuzzle server controller to return plugins customs routes. |
|
The issue resolved by this PR here is that, without rights to Moreover, between |
|
@Aschen : Does the @scottinet's answer satisfied you? |
alexandrebouthinon
force-pushed
the
KZL-996-http-routes
branch
from
639e6a0 to
ece089b
Compare
To permit the HTTP protocol to not have to performs request on Kuzzle to fetch all available `vanilla` routes.
What does this PR do?
Save Kuzzle API routes in a json file to permit the HTTP protocol to not have to performs request on Kuzzle to fetch all available
vanillaroutes.How should this be manually tested?
Run Unit test and/or use HTTP protocol