- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
Expose protocols classes #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report
 @@            Coverage Diff             @@
##            6-dev     #341      +/-   ##
==========================================
- Coverage   97.23%   96.56%   -0.67%     
==========================================
  Files          28       27       -1     
  Lines        1410     1397      -13     
==========================================
- Hits         1371     1349      -22     
- Misses         39       48       +9
 Continue to review full report at Codecov. 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
A few minor remarks, but otherwise it looks good to me.
Co-Authored-By: Aschen <amaret93@gmail.com>
| Awesome good job @Aschen | 
…ascript into expose-protocol-classes
What does this PR do?
Expose protocol classes (
Websocket,HttpandSocketIO) in the root module.Also remove the
networkWrapper.Documentation PR: kuzzleio/documentation#180
How should this be manually tested?
Run this snippet and the unit tests:
Other changes
KuzzleAbstractNetworktoKuzzleAbstractProtocol