'ms:sort' needs its options in the request's body #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6-dev #337 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 28 28
Lines 1401 1401
=======================================
Hits 1363 1363
Misses 38 38
Continue to review full report at Codecov.
|
Aschen
approved these changes
Nov 16, 2018
Njuelle
approved these changes
Nov 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The memory storage
sortmethod is configured as a getter, meaning that its options are put at the root level of the sent json query.But, as stated by the API documentation, these options are expected in the "body" part of the request (because of the "store" option).
So, in its current state, options set for this command using the SDK are ignored by Kuzzle.
This PR puts the options at their expected location, making Kuzzle correctly process the sort command.