Skip to content

Conversation

@Aschen
Copy link
Contributor

@Aschen Aschen commented Oct 22, 2018

What does this PR do?

When harmonizing the documentation for the SDJ JS 6, I noticed a few things that deserve to be corrected

  • The method auth:updateSelf was returning a promise that resolve to a JSON object.
    ➡️ Change the value resolved by the promise to a User object, like the getCurrentUser method

  • The method collection:updateSpecification return an object containing the index and the collection where the specifications were updated.
    ➡️ Return only the updated specifications

How should this be manually tested?

  • Step 1 : Run tests

@Aschen Aschen self-assigned this Oct 22, 2018
@codecov-io
Copy link

codecov-io commented Oct 22, 2018

Codecov Report

Merging #326 into 6-dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            6-dev     #326   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          28       28           
  Lines        1401     1401           
=======================================
  Hits         1363     1363           
  Misses         38       38
Impacted Files Coverage Δ
src/controllers/bulk.js 100% <100%> (ø) ⬆️
src/controllers/auth.js 92.5% <100%> (ø) ⬆️
src/controllers/collection.js 94.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2386fa8...dac2d70. Read the comment docs.

@Aschen Aschen changed the base branch from master to 6-dev October 23, 2018 09:01
@Aschen Aschen changed the title Fix method updateSelf to return a User object Harmonize SDK Oct 23, 2018
@Aschen Aschen added the wip label Oct 23, 2018
@Aschen Aschen added wip and removed wip labels Nov 1, 2018
@Aschen Aschen removed the wip label Nov 13, 2018
@Aschen Aschen merged commit f2f285b into 6-dev Nov 14, 2018
@Aschen Aschen deleted the fix-update-self-return branch November 14, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants