HTTP Protocol suport #271
Merged
HTTP Protocol suport #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
February 21, 2018 19:10
* browser support via `XMLHttpRequest` * nodejs support via `http.request`
Codecov Report
@@ Coverage Diff @@
## 6.x #271 +/- ##
==========================================
- Coverage 83.98% 80.27% -3.71%
==========================================
Files 17 19 +2
Lines 1917 2023 +106
==========================================
+ Hits 1610 1624 +14
- Misses 307 399 +92
Continue to review full report at Codecov.
|
scottinet
reviewed
Mar 9, 2018
| } | ||
| }); | ||
| } | ||
| // Track requests made to allow Room.subscribeToSelf to work |
There was a problem hiding this comment.
this comment seems to be a leftover from previous sdk versions
scottinet
approved these changes
Mar 9, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for HTTP protocol
fix #167
fix also #282