- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
Make collection.create() pass the collection object to the callback #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report
 @@            Coverage Diff             @@
##              5.x     #245      +/-   ##
==========================================
+ Coverage   98.27%   98.27%   +<.01%     
==========================================
  Files          17       17              
  Lines        2148     2149       +1     
  Branches      610      611       +1     
==========================================
+ Hits         2111     2112       +1     
  Misses         37       37
 Continue to review full report at Codecov. 
 | 
| This needs an update to the SDK documentation and to other SDKs as well | 
        
          
                test/network/networkWrapper.test.js
              
                Outdated
          
        
      | window = undefined; // eslint-disable-line | ||
| WebSocket = undefined; // eslint-disable-line | ||
| window = undefined; | ||
| /*eslint no-native-reassign: "off"*/ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking: this disables the rule for the entire file. Prefer the following:
// eslint-disable-next-line no-native-reassign, no-global-assign
The method
kuzzle.collection('foo').create()passed to the callback the response from the server. We estimate that passing the collection makes the API easier to use. It notably allows to doBoyscouting
Included
kuzzle.createIndexin the promisification whitelist.