Skip to content

Conversation

@samniisan
Copy link
Contributor

@samniisan samniisan commented Jun 28, 2017

Introduces

  • Meta in Security documents (User, Profile, Role)

Should only be merged after Kuzzle side PR
kuzzleio/kuzzle#897

@codecov-io
Copy link

codecov-io commented Jun 28, 2017

Codecov Report

Merging #236 into 5.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #236      +/-   ##
==========================================
+ Coverage   98.41%   98.46%   +0.04%     
==========================================
  Files          17       17              
  Lines        2144     2147       +3     
  Branches      610      611       +1     
==========================================
+ Hits         2110     2114       +4     
+ Misses         34       33       -1
Impacted Files Coverage Δ
src/Collection.js 98.03% <ø> (ø) ⬆️
src/security/SecurityDocument.js 100% <100%> (ø) ⬆️
src/security/Security.js 97.74% <100%> (ø) ⬆️
src/Kuzzle.js 98.94% <100%> (+0.17%) ⬆️
src/security/Profile.js 100% <100%> (ø) ⬆️
src/security/User.js 98.76% <100%> (ø) ⬆️
src/security/Role.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d614dd...769bfb0. Read the comment docs.

@scottinet scottinet merged commit 4ecab74 into 5.x Jul 3, 2017
@scottinet scottinet deleted the 36-security-meta branch July 3, 2017 08:48
@stafyniaksacha stafyniaksacha mentioned this pull request Jul 19, 2017
@scottinet scottinet mentioned this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants