Add SDK version into volatile #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samniisan
commented
Jun 16, 2017
samniisan
commented
- Adds the current version of the SDK into volatile for every Kuzzle query.
- Modified webpack config to integrate the version at build time.
Codecov Report
@@ Coverage Diff @@
## 5.x #232 +/- ##
==========================================
+ Coverage 98.41% 98.69% +0.28%
==========================================
Files 17 17
Lines 2142 2449 +307
Branches 609 725 +116
==========================================
+ Hits 2108 2417 +309
+ Misses 34 32 -2
Continue to review full report at Codecov.
|
stafyniaksacha
approved these changes
Jun 19, 2017
scottinet
reviewed
Jun 19, 2017
src/Kuzzle.js
Outdated
| writable: true | ||
| }, | ||
| sdkVersion: { | ||
| value: (typeof SDKVERSION === 'undefined') ? JSON.parse(require('fs').readFileSync('package.json', {encoding: 'utf-8'})).version : SDKVERSION, |
There was a problem hiding this comment.
You can require a JSON file directly:
value: (typeof SDKVERSION === 'undefined') ? require('../package.json').version : SDKVERSION
benoitvidis
approved these changes
Jun 19, 2017
samniisan
force-pushed
the
35-sdk-version
branch
from
63ec213 to
9a1db7e
Compare
jenow
approved these changes
Jun 20, 2017
scottinet
approved these changes
Jun 20, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.