Fix createProfile and updateProfile method signatures #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #230 +/- ##
==========================================
+ Coverage 98.24% 98.24% +<.01%
==========================================
Files 17 17
Lines 2050 2052 +2
Branches 590 592 +2
==========================================
+ Hits 2014 2016 +2
Misses 36 36
Continue to review full report at Codecov.
|
dbengsch
approved these changes
Jun 7, 2017
stafyniaksacha
approved these changes
Jun 7, 2017
benoitvidis
approved these changes
Jun 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following kuzzleio/sdk-android#133 (review), the
Security.createProfileandSecurity.updateProfilemethods now take apoliciesargument, which is an array of policies to apply to the corresponding profile, instead of acontentargument, an object containing apolicieskey containing the list of policies to apply.