remove fetchAllDocuments method #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samniisan
approved these changes
Jun 6, 2017
samniisan
approved these changes
Jun 6, 2017
benoitvidis
force-pushed
the
ref-23-remove-fetchalldocuments
branch
from
bde39e2 to
e76204c
Compare
Codecov Report
@@ Coverage Diff @@
## 5.x #228 +/- ##
==========================================
+ Coverage 98.24% 98.51% +0.27%
==========================================
Files 17 17
Lines 2050 2027 -23
Branches 590 583 -7
==========================================
- Hits 2014 1997 -17
+ Misses 36 30 -6
Continue to review full report at Codecov.
|
dbengsch
approved these changes
Jun 7, 2017
stafyniaksacha
approved these changes
Jun 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
fetchAllDocumentsmethod from the SDK, which can be better replaced by asearch+fetchNextcall (documentation to come).