Add support for Document:m* methods #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #224 +/- ##
==========================================
+ Coverage 98.15% 98.27% +0.12%
==========================================
Files 17 17
Lines 1953 2032 +79
Branches 556 584 +28
==========================================
+ Hits 1917 1997 +80
+ Misses 36 35 -1
Continue to review full report at Codecov.
|
dbengsch
approved these changes
May 30, 2017
benoitvidis
reviewed
May 30, 2017
src/Collection.js
Outdated
| }, | ||
| self = this; | ||
|
|
||
| if (!Array.isArray(documents)) { |
There was a problem hiding this comment.
open question: would it be simpler to send this error in the callback? Else, the end-user will have to write somehting like
try {
collection.mcreate(docs, function (error, response) {
if (error) {
// 1st error handling
}
});
}
catch (e) {
// 2nd error handling
}There was a problem hiding this comment.
Indeed, I will update this and let you know 👍
scottinet
approved these changes
Jun 1, 2017
ballinette
approved these changes
Jun 1, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
fix https://github.com/kuzzleio/kuzzle-sdk/issues/6