-
Notifications
You must be signed in to change notification settings - Fork 17
Add kuzzle info in Document object #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.x #200 +/- ##
==========================================
+ Coverage 99.35% 99.36% +<.01%
==========================================
Files 16 16
Lines 1718 1720 +2
Branches 458 459 +1
==========================================
+ Hits 1707 1709 +2
Misses 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, but I'm not fond of the kuzzleInfo name. I mean, without context, my first thought is that this property provides informations about Kuzzle.
This also opens a (hopefully quick) discussion on how to name this property in our API (maybe not for the internal storage name, as this name pretty much ensures that there won't be collisions with actual documents).
When documents are exported by our API (and exposed in our SDKs), I think it might be better to rename it for something clearer, like _properties for instance.
|
@scottinet totally agree with you. I thought it was a good idea to keep the same name between attribute returned by the API and the attribute returned by the SDK. |
The kuzzleInfo attribute is now called meta
No description provided.