Stop calling onClientError when disconnect is called

[jenow]

Fix https://github.com/kuzzleio/sdk/issues/16

[codecov-io]

Codecov Report

Merging #194 into 4.x will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              4.x     #194      +/-   ##
==========================================
+ Coverage   99.36%   99.41%   +0.05%     
==========================================
  Files          16       16              
  Lines        1721     1724       +3     
  Branches      458      458              
==========================================
+ Hits         1710     1714       +4     
+ Misses         11       10       -1

Impacted Files	Coverage Δ
src/networkWrapper/wrappers/websocket.js	100% <100%> (ø)	✅
src/Kuzzle.js	99.63% <0%> (+0.18%)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2488d...1dc1716. Read the comment docs.

[scottinet]

I disagree with the way this PR is implemented.

To me, this bug occurs because the close method does not do its job correctly, leaving the auto-reconnection process alive instead of stopping it.

Instead of adding additional complexity to the current state machine, I propose to keep a reference to the auto-reconnection setTimeout timer, and then having the close method use it to remove the timer from the event loop.

[ballinette]

Note: the related issue will be fixed by another way when the network wrappers will be refactored.
If the bug is blocking, we can accept this quick fix.
If not, it's better to wait for the deep network wrappers refactoring.

[scottinet]

Ok, accepting this fix for now since it'll be implemented in a cleaner way later.