Skip to content

Conversation

@dbengsch
Copy link
Contributor

@dbengsch dbengsch commented Mar 8, 2017

Breaking changes:

  • Align SearchResult constructor signature with other SDKs
  • Rename next into fetchNext
  • Move the scroll option into the scroll action signature

Other changes:

  • Add getters on SearchResult

Boyscout:

  • Renaming of some variables
    • dataCollection => collection
    • KuzzleSubscribeResult => SubscribeResult
    • KuzzleSearchResult => SearchResult
    • KuzzleSecurityDocument => SecurityDocument

documentation: kuzzleio/documentation#139
fix: https://github.com/kuzzleio/sdk/issues/13

@dbengsch dbengsch self-assigned this Mar 8, 2017
@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #190 into 4.x will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              4.x     #190      +/-   ##
==========================================
- Coverage   99.39%   99.33%   -0.06%     
==========================================
  Files          16       16              
  Lines        1646     1660      +14     
  Branches      439      439              
==========================================
+ Hits         1636     1649      +13     
- Misses         10       11       +1
Impacted Files Coverage Δ
src/Room.js 100% <100%> (ø)
src/security/Role.js 100% <100%> (ø)
src/security/SecurityDocument.js 100% <100%> (ø)
src/Collection.js 96.94% <100%> (-0.45%)
src/security/Profile.js 100% <100%> (ø)
src/SearchResult.js 100% <100%> (ø)
src/SubscribeResult.js 100% <100%> (ø)
src/Document.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3eee3...e5d7801. Read the comment docs.

@dbengsch dbengsch merged commit caebd3e into 4.x Mar 10, 2017
@dbengsch dbengsch deleted the topic-18-align-search-result branch March 10, 2017 13:58
This was referenced Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants