Skip to content

Conversation

@benoitvidis
Copy link
Contributor

@benoitvidis benoitvidis commented Feb 28, 2017

Description

In some circumstances, we may want to use the same kuzzle object and change its options, for instance to switch to another environment.

This PR allows to update any possible option given to Kuzzle constructor.

Notably, this allows to switch the connection mode back from or to ssl on the current kuzzle instance, without having to create a new object.

Linked issue

kuzzleio/kuzzle-admin-console#154

Linked PRs

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          16       16           
  Lines        1665     1665           
  Branches      441      441           
=======================================
  Hits         1655     1655           
  Misses         10       10
Impacted Files Coverage Δ
src/Kuzzle.js 99.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97ae12...8dfde19. Read the comment docs.

@scottinet scottinet merged commit 3421a74 into master Feb 28, 2017
@scottinet scottinet deleted the make-all-constructor-options-writable branch February 28, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants