Browsers compatibility fix #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While scanning this SDK code to fix an unrelated documentation issue, I came across a
process.nextTickcall, which is a pure-NodeJS method.So, I fixed that. Which led to a failed unit test, also relying on
process.nextTick.It came to me that having a browser-compatible code tested with ES6 and/or NodeJS specific code was not a good idea, so I modified ESLint to make sure our code and tests are using the same standards, and reverted unit tests from ES6 to ES5.