make subscribe.onDone foolproof #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stafyniaksacha
approved these changes
Sep 23, 2016
Current coverage is 100% (diff: 100%)@@ develop #119 diff @@
=====================================
Files 16 16
Lines 1563 1569 +6
Methods 268 268
Messages 0 0
Branches 398 399 +1
=====================================
+ Hits 1563 1569 +6
Misses 0 0
Partials 0 0
|
benoitvidis
approved these changes
Sep 23, 2016
dbengsch
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the subscription callbacks are correctly called in the unlikely event of invoking the
onDonemethod after Kuzzle responds.For instance, if one stores the
KuzzleDataCollection.subscribeor theKuzzleDocument.subscriberesult, and then invokes itsonDonemethod a few milliseconds after that.