Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Conversation

@samniisan
Copy link
Contributor

@samniisan samniisan commented Jul 5, 2017

  • Fixed the multiple subscription issue (when subscribing multiple times with the same filters, Socket.io wouldn't use the already existing connexion and created a new one, the proxy would then consider that the subscription was made by anoter client)
  • Crash when receiving a Notification with "unknown" scope (delete queries), missing value in ENUM
  • Fixed missing _meta in Document entity created upon receiving a Document Notification (create, replace etc.)

@codecov-io
Copy link

codecov-io commented Jul 5, 2017

Codecov Report

Merging #147 into 3.x will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.x     #147      +/-   ##
==========================================
- Coverage   91.49%   91.42%   -0.08%     
==========================================
  Files          32       32              
  Lines        4692     4697       +5     
  Branches      438      439       +1     
==========================================
+ Hits         4293     4294       +1     
- Misses        272      276       +4     
  Partials      127      127
Impacted Files Coverage Δ
src/main/java/io/kuzzle/sdk/enums/Users.java 100% <ø> (ø) ⬆️
.../io/kuzzle/sdk/responses/NotificationResponse.java 28.57% <0%> (-3.69%) ⬇️
src/main/java/io/kuzzle/sdk/core/Kuzzle.java 92.24% <100%> (ø) ⬆️
src/main/java/io/kuzzle/sdk/enums/Scope.java 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac7ba0...1858b69. Read the comment docs.

@benoitvidis benoitvidis merged commit 8eddc21 into 3.x Jul 11, 2017
@benoitvidis benoitvidis deleted the subscribe-issues branch July 11, 2017 07:09
@stafyniaksacha stafyniaksacha mentioned this pull request Jul 19, 2017
@scottinet scottinet mentioned this pull request Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants