Remove Data Collection and Data index #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snippets tests reports
|
scottinet
suggested changes
Mar 27, 2019
|
|
||
| // Freshly installed Kuzzle servers are empty: we first need to create | ||
| // a data index. The one used in this example is named "nyc-open-data" | ||
| // a index. The one used in this example is named "nyc-open-data" |
There was a problem hiding this comment.
There are other occurences of this error, and they should all be fixed.
Suggested change
| // a index. The one used in this example is named "nyc-open-data" | |
| // an index. The one used in this example is named "nyc-open-data" |
…ation into remove-data-collection
scottinet
suggested changes
Mar 27, 2019
index.js
Outdated
|
|
||
| if (options.algolia.privateKey) { | ||
| log('Algolia indexing enabled'); | ||
| log('Algolian indexing enabled'); |
There was a problem hiding this comment.
I... think that you should check your regexes before applying them. 😑
alexandrebouthinon
approved these changes
Mar 27, 2019
scottinet
approved these changes
Mar 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace references to
data collectionanddata indexbyindexandcollection