Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@royi-luo
Copy link
Contributor

@royi-luo royi-luo commented Jul 4, 2025

Closes #541

Contributor agreement

@royi-luo royi-luo requested a review from prrao87 July 4, 2025 14:23
@royi-luo royi-luo self-assigned this Jul 4, 2025
@sdht0
Copy link
Contributor

sdht0 commented Jul 4, 2025

Here's a thought: how about we move even all existing doc about df to use the parameter based style?
I think we shouldn't encourage the somewhat magical in-string style anymore.

@royi-luo royi-luo force-pushed the royi/dataframe-param-docs branch from 99c7d7c to 1ad9789 Compare July 4, 2025 18:02
This is useful when you are doing your data transformations with these libraries and rapidly ingest
their columns into Kuzu node or relationship tables.

There are two different ways in Kuzu to reference dataframes:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdht0 I updated all the examples to use the parameterized dataframes and left a section in describing the old method (since it's still a valid legacy method). Can you take another look and see if everything looks good?

@royi-luo royi-luo requested a review from sdht0 July 4, 2025 18:04
@royi-luo royi-luo force-pushed the royi/dataframe-param-docs branch from f976ea0 to f90e599 Compare July 4, 2025 18:19
@royi-luo royi-luo force-pushed the royi/dataframe-param-docs branch from f90e599 to 8cbce00 Compare July 4, 2025 18:21
Copy link
Contributor

@sdht0 sdht0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored the dataframes content quite a bit

@royi-luo royi-luo merged commit 8baeb83 into dev Jul 4, 2025
1 check passed
@royi-luo royi-luo deleted the royi/dataframe-param-docs branch July 4, 2025 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants