Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@tgahunia05
Copy link
Contributor

Contributor agreement

@tgahunia05 tgahunia05 self-assigned this Jun 13, 2025
@prrao87
Copy link
Contributor

prrao87 commented Jun 13, 2025

@ray6080 if this extension's purpose is only to provide embedding function calls from Cypher, shouldn't we call this an "embeddings extension"? LLM extension is quite broad and can mean different things to different people. Also, technically, speaking, LLMs do not do embedding (they are generative models trained on left-to-right token sequences -- embedding models are a totally different class of models trained via contrastive learning).

@tgahunia05 tgahunia05 changed the base branch from main to dev June 13, 2025 16:25
Copy link
Contributor

@prrao87 prrao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and questions.

Copy link
Contributor

@sdht0 sdht0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take another look.

tgahunia05 and others added 12 commits June 23, 2025 13:08
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
Co-authored-by: Siddhartha Sahu <sid@kuzudb.com>
@tgahunia05 tgahunia05 requested review from prrao87 and sdht0 June 23, 2025 18:33
Copy link
Contributor

@sdht0 sdht0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge once the Python scripts are tested.

@tgahunia05 tgahunia05 marked this pull request as ready for review June 25, 2025 20:20
@tgahunia05 tgahunia05 merged commit 1a69ec5 into dev Jun 25, 2025
1 check passed
@tgahunia05 tgahunia05 deleted the llm-docs branch June 25, 2025 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants