Reject passwords with leading/trailing whitespace in registration#34
Draft
Reject passwords with leading/trailing whitespace in registration#34
Conversation
Co-authored-by: Kushmanmb <193178375+Kushmanmb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix user authentication issue on login page
Reject passwords with leading/trailing whitespace in registration
Feb 10, 2026
| } | ||
|
|
||
| // Validate password does not have leading or trailing whitespace | ||
| if (password !== password.trim()) { |
Check failure
Code scanning / Bearer
Observable Timing Discrepancy Error
| } else if (formData.password.length < 8) { | ||
| newErrors.password = 'Password must be at least 8 characters'; | ||
| } else if (formData.password !== formData.password.trim()) { | ||
| newErrors.password = 'Password cannot have leading or trailing spaces'; |
Check failure
Code scanning / Bearer
Usage of hard-coded secret Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passwords with leading or trailing whitespace were accepted during registration, creating authentication issues when login flows handle whitespace inconsistently.
Changes
UserRegistrationForm.tsx): Reject passwords wherepassword !== password.trim()route.ts): Return 400 with clear error for whitespace-padded passwordsroute.test.ts): Validate whitespace handling, including passwords with internal spaces (permitted)Internal spaces remain valid (e.g.,
"my pass word"is accepted," password "is rejected).Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.