Ignore asset url query string or anchor when appending extensions and…

… computing public path
kushkella · Oct 15, 2012 · c4276dd · c4276dd
1 parent 046ab84
commit c4276dd
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/actionpack/lib/action_view/helpers/asset_url_helper.rb b/actionpack/lib/action_view/helpers/asset_url_helper.rb
@@ -122,6 +122,8 @@ def asset_path(source, options = {})
         return "" unless source.present?
         return source if source =~ URI_REGEXP
 
+        tail, source = source[/([\?#].+)$/], source.sub(/([\?#].+)$/, '')
+
         if extname = compute_asset_extname(source, options)
           source = "#{source}#{extname}"
         end
@@ -140,7 +142,7 @@ def asset_path(source, options = {})
           source = "#{host}#{source}"
         end
 
-        source
+        "#{source}#{tail}"
       end
       alias_method :path_to_asset, :asset_path # aliased to avoid conflicts with a asset_path named route
 

diff --git a/actionpack/test/template/asset_tag_helper_test.rb b/actionpack/test/template/asset_tag_helper_test.rb
@@ -73,7 +73,12 @@ def url_for(*args)
     %(javascript_path("super/xmlhr")) => %(/javascripts/super/xmlhr.js),
     %(javascript_path("/super/xmlhr.js")) => %(/super/xmlhr.js),
     %(javascript_path("xmlhr.min")) => %(/javascripts/xmlhr.min.js),
-    %(javascript_path("xmlhr.min.js")) => %(/javascripts/xmlhr.min.js)
+    %(javascript_path("xmlhr.min.js")) => %(/javascripts/xmlhr.min.js),
+
+    %(javascript_path("xmlhr.js?123")) => %(/javascripts/xmlhr.js?123),
+    %(javascript_path("xmlhr.js?body=1")) => %(/javascripts/xmlhr.js?body=1),
+    %(javascript_path("xmlhr.js#hash")) => %(/javascripts/xmlhr.js#hash),
+    %(javascript_path("xmlhr.js?123#hash")) => %(/javascripts/xmlhr.js?123#hash)
   }
 
   PathToJavascriptToTag = {
@@ -285,6 +290,14 @@ def url_for(*args)
     %(audio_tag(["audio.mp3", "audio.ogg"], :autobuffer => true, :controls => true)) => %(<audio autobuffer="autobuffer" controls="controls"><source src="/audios/audio.mp3" /><source src="/audios/audio.ogg" /></audio>)
   }
 
+  FontPathToTag = {
+    %(font_path("font.eot")) => %(/fonts/font.eot),
+    %(font_path("font.eot#iefix")) => %(/fonts/font.eot#iefix),
+    %(font_path("font.woff")) => %(/fonts/font.woff),
+    %(font_path("font.ttf")) => %(/fonts/font.ttf),
+    %(font_path("font.ttf?123")) => %(/fonts/font.ttf?123)
+  }
+
   def test_autodiscovery_link_tag_deprecated_types
     result = nil
     assert_deprecated do
@@ -466,6 +479,10 @@ def test_audio_tag
     AudioLinkToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) }
   end
 
+  def test_font_path
+    FontPathToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) }
+  end
+
   def test_video_audio_tag_does_not_modify_options
     options = {:autoplay => true}
     video_tag('video', options)