Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeyStore to use Path than string #148

Closed
kushaldas opened this issue Nov 14, 2023 · 2 comments · Fixed by #149
Closed

Update KeyStore to use Path than string #148

kushaldas opened this issue Nov 14, 2023 · 2 comments · Fixed by #149
Assignees

Comments

@kushaldas
Copy link
Owner

Right now we are using strings to store the KeyStore database path. We should instead use pathlib.Path everywhere. This will also help for the tests on Windows.

@kushaldas kushaldas self-assigned this Nov 14, 2023
@euri10
Copy link
Contributor

euri10 commented Nov 14, 2023

I came to the same conclusion looking at your PR @kushaldas , which I expanded on ( see below), solved almost all issues but a rather big and annoying one on th db upgrade, it fails on renaming the file with a PermissionError
I ended up giving up because I dont have windows and debugging in the CI was rather not fun

https://github.com/euri10/johnnycanencrypt/tree/tests_on_windows

@kushaldas
Copy link
Owner Author

I ended up giving up because I dont have windows and debugging in the CI was rather not fun

I can understand the pain :) I am focusing on all the other things to clean up first. And then I will look into Windows update. One step at a time.
I may do a few more PRs before I go back to windows land. We will know soon :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants