Repository navigation
Ignore unmatched Creative Commons license end tags - #603
Open
terminalchai wants to merge 1 commit into
Open
terminalchai wants to merge 1 commit into
terminalchai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unmatched Creative Commons license closing tag, such as
</creativeCommons:license>, currently makesfeedparser.parse()raiseKeyError: 'license'. Return when there is no matching license element, preserving existing license links and surrounding text without adding a spurious link.This addresses the Creative Commons license cases reported in #599; other malformed-feed cases in that issue are outside this change.
Adds 14 regression cases covering bare closing tags, feed and entry contexts, namespace aliases, repeated closing tags after a valid license, and closing tags within title text. Includes a changelog fragment.
Validation on Windows with Python 3.11:
KeyErrorbefore the fix and pass afterward.git diff --checkpass.Prepared with AI assistance; the diff and regression results were reviewed before submission.