[release/v26.0] [DB-2199] Fix write timeout regressions introduced with multi-stream appends - #5702
Draft
shaan1337 wants to merge 1 commit into
Draft
[release/v26.0] [DB-2199] Fix write timeout regressions introduced with multi-stream appends#5702shaan1337 wants to merge 1 commit into
shaan1337 wants to merge 1 commit into
Conversation
The failure constructor of `WriteEventsCompleted` leaves `FirstEventNumbers` and `LastEventNumbers` empty, so `LowAllocReadOnlyMemory<T>.Single` throws when the write result is not `Success`. Two write completion callbacks read them unconditionally, and the throw happens before the failure handling runs. - `CoreProjectionCheckpointWriter`: a failed checkpoint write is neither retried nor reported as a projection failure. The projection stops processing events and just sits at `Writing (N)` until the node or the projection subsystem is restarted. - `PersistentSubscriptionMessageParker`: a failed park write is not retried and the event is silently lost - neither delivered, nor retried, nor written to the parked stream. The consumer's in-flight slot is leaked too, so enough failed parks and the connection stops receiving messages. Guard both reads on `OperationResult.Success` and add a test for each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually cherry picked from #5699
(only tests had merge conflicts)