[ESDB-116-4] Add Catchup Subscription Metrics #4279
Conversation
thefringeninja
force-pushed
the
ketchup-metrics
branch
from
b77956f to
b8b9277
Compare
| public void ProcessEvent(string? streamName, long commitPosition, long eventPosition) { | ||
| foreach (var (_, stats) in _subscriptionStats) { | ||
| if (stats.StreamName == streamName) { | ||
| _subscriptionStats.TryUpdate(stats.SubscriptionId, stats with { | ||
| SubscriptionPosition = eventPosition | ||
| }, stats); | ||
| } else if (stats.StreamName is null) { | ||
| _subscriptionStats.TryUpdate(stats.SubscriptionId, stats with { | ||
| SubscriptionPosition = commitPosition | ||
| }, stats); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
- similarly, quite expensive to do for every event that we send to a subscription?
- also we probably want to update the specific subscription that processed this event or all the subscriptions will have the same position
src/EventStore.Core/Services/Transport/Enumerators/Enumerator.AllSubscriptionFiltered.cs
Show resolved
Hide resolved
timothycoleman
left a comment
timothycoleman
left a comment
There was a problem hiding this comment.
questions/suggestions above
|
|
||
| meter.CreateObservableUpDownCounter($"{name}-completed", Completed); | ||
| meter.CreateObservableUpDownCounter($"{name}-subscription-position", SubscriptionPosition); | ||
| meter.CreateObservableUpDownCounter($"{name}-stream-position", StreamPosition); |
There was a problem hiding this comment.
the ticket talks about having the timestamps of the current vs latest events, is that still in scope?
There was a problem hiding this comment.
If we use the read index we could read the last event to get that info, but dunno how expensive that is every n seconds. We would have to expose IAllReader to do it for the all stream
Or we go back to using EventCommitted
Or, we could occasionally update this from the grpc subscription
| public void Add(Guid subscriptionId, string? streamName, long endOfStream) => | ||
| _subscriptionStats.TryAdd(subscriptionId, new(subscriptionId, streamName, EndOfStream: endOfStream)); | ||
|
|
||
| public void Remove(Guid subscriptionId) => _subscriptionStats.TryRemove(subscriptionId, out _); |
There was a problem hiding this comment.
could you double check what happens in the dashboard if we stop reporting a particular subscription, does it stop drawing it or does it just keep drawing the last reported values for a while
thefringeninja
force-pushed
the
ketchup-metrics
branch
from
b8b9277 to
4a841ea
Compare
thefringeninja
force-pushed
the
ketchup-metrics
branch
from
d2d8408 to
527be4d
Compare
|
|
4 participants
Added: new metrics for catchup subscriptions