Make the Left aligned Title placement follow the horizontal button offset

[ryu-ketsueki]

Title on left alignment is too close to the edge. Perhaps it would be a good idea to make it follow the horizontal button offset

[kupiqu]

Is this a bug in SBE wrt Breeze or a feature request?

[ryu-ketsueki]

It seems to be a bug, yeah. I also observed that the title only takes that space when there are no buttons on the left but the titlebar only updates the part that did respect the horizontal offset, with the rest staying there until the window loses focus

[kupiqu]

Could you elaborate a little bit? I don't understand if this is a bug in SBE or Breeze (although I suppose it's SBE) and not sure either what these screenshots show. I don't use Discord myself so not sure what to expect.

[ryu-ketsueki]

The first one shows the name of a Direct Message Group (PS Screenshots). Later, I clicked to open an actual Direct Message with a friend in the list. Discord shows the At symbol then the username. That means that when the titlebar updates to show that it's a direct message with a friend, it didn't update for the area that was supposed to be free as indicated by the P still showing up when it updates to @jeanca. This seem to be happening with the default breeze as well, now that you mention it. I should probably open a bug report with them as well. But while Breeze doesn't have the horizontal offset option, SBE does and it could be used for the Left aligned titlebar title as well, that way the padding can be adjusted to match the one of the buttons on the right

[kupiqu]

So, if I understand this correctly there are two issues actually here (correct me if wrong):

• The titlebar does not get updated properly (upstream issue).
  Please report that to kde... If you open another issue here and link to the bug in kde, I can track how this issue evolves and if fixed in kde, I can incorporate that to SBE.

• In absence of buttons, the offset on the left is not the same that the offset on the right (SBE issue)
  Could you paste a couple of screenshots showing the different behavior of this, left vs right?

[ryu-ketsueki]

I will report it to KDE, don't worry. I kinda stumbled it after I opened this issue here on SBE




As for the second issue, basically the title is too far on the left, not respecting the horizontal offset feature of SBE. Not really an issue with buttons on the left, only being a bit too close to the buttons but that's just a spacing nitpicking. And the last screenshot shows that the same happens if the title alignment is on the right with no buttons on the right.

[kupiqu]

Ok, I see, the issue is (mainly) about the behavior without buttons.

• if buttons are not present, the offset should apply to them? I guess so
• if buttons are present, the separation should be reasonable, perhaps a bit larger than currently, but I would need to know if current one is smaller than that of breeze. Could you please check?

[ryu-ketsueki]

This is Breeze:

And this is SBE:

I think Breeze's own spacing is consistent with what they are trying to do, yeah. I noticed that when the window decoration changed from Breeze to SBE, the spacing between the title and the button shortened a bit but was only clear when I was directly overving it. Comparing screenshots doesn't make it very clear.

[kupiqu]

@ryu-ketsueki I think the issue is about the offset in absence of buttons. I think it won't be hard to fix. Would you give it a try and submit a pull request?

[kupiqu]

I'll set this as a low priority bug for now, maybe somebody picks it up.

[kupiqu]

My aim is that SBE is maintained by the community. This shouldn't be hard to fix. I hope someone in the community cares about SBE and submits a pull request about it... I could help if somebody wants to try but is lost where to start.