Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nodejs 6.x (update nan, use node-gyp) #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dankang
Copy link
Contributor

@dankang dankang commented Jun 22, 2016

  • update nan version (2.1.0 => 2.3.5)
  • use node-gyp instead of pangyp(deprecated)
  • tested on nodejs 4.4.5 & 6.2.2

* update nan version (2.1.0 => 2.3.5)
* use node-gyp instead of pangyp(deprecated)
* tested on nodejs 4.4.5 & 6.2.2
@dankang dankang changed the title chore & test: update library & use node-gyp for test support nodejs 6.x (update nan, use node-gyp) Jun 22, 2016
@dankang
Copy link
Contributor Author

dankang commented Jun 22, 2016

@kuno
Right now, I can only check Travis CI build results.
If you give me the access permission for AppVeyor, Wercker.. I will fix build failure.

Shankar Karuppiah and others added 2 commits July 16, 2016 23:55
@fmasuhr
Copy link

fmasuhr commented Jul 19, 2016

@kuno is there any chance to get this merged? There are multiple security issues in the pangyp dependencies since it is deprecated.

@chetverikov
Copy link

+1

@diversario
Copy link

node v6 has moved into active LTS mode and a lot of people can't upgrade their projects (myself included) because we have a dependency on this package. This PR really needs to be rolled in at least to make it possible to upgrade.

@luigizuccarelli
Copy link

@kuno - what is the status on this ?. We have an urgent need to have this mergerd due to nsp checks

 minimatch   2.0.10      >=3.0.2                      fh-messaging@3.0.2-BUILD-NUMBER > geoip@0.6.1 > pangyp@2.3.3 > glob@4.3.5 > minimatch@2.0.10   https://nodesecurity.io/advisories/118 
 minimatch   2.0.10      >=3.0.2                      fh-messaging@3.0.2-BUILD-NUMBER > geoip@0.6.1 > pangyp@2.3.3 > minimatch@2.0.10                https://nodesecurity.io/advisories/118 

@CaptEmulation
Copy link

CaptEmulation commented Apr 25, 2018

I needed this so I created @captemulation/geoip@0.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants