Skip to content

added tic tac toe#333

Merged
kunjgit merged 6 commits intokunjgit:mainfrom
SimranLahrani842:tictactoe
May 27, 2023
Merged

added tic tac toe#333
kunjgit merged 6 commits intokunjgit:mainfrom
SimranLahrani842:tictactoe

Conversation

@SimranLahrani842
Copy link
Contributor

PR Description 📜

Tic Tac Toe
Fixes #18
I have added tic-tac-toe game where alternate chance is given to X and O.
Game can also be reset if required.
The chance of player each time and the winner is displayed.
Sound occurs on clicking the the box.

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot (491)

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 23, 2023

Thank you @SimranLahrani842 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@SimranLahrani842
Copy link
Contributor Author

Added all files and image in assets folder updates readme.md in main and resolved conflicts.
Kindly review my PR @kunjgit

@kunjgit
Copy link
Owner

kunjgit commented May 24, 2023

Hey @SimranLahrani842 👋!

@kunjgit here,
We have this annoucement to make 📢!!
During the time of PR don't alter main index file ! 🙂
In main Readme file just use * as a game number during the time we are merging we will add number !! 👀
Make sure you join our Discord🕹️ if you haven't 😇
Thank you 💗!

@SimranLahrani842
Copy link
Contributor Author

Hey @SimranLahrani842 👋!

@kunjgit here, We have this annoucement to make 📢!! During the time of PR don't alter main index file ! 🙂 In main Readme file just use * as a game number during the time we are merging we will add number !! 👀 Make sure you join our Discord🕹️ if you haven't 😇 Thank you 💗!

added * instead of number..please review pr and merge it @kunjgit

@Arun9739
Copy link
Contributor

@SimranLahrani842 Please resolve the branch conflicts

@SimranLahrani842
Copy link
Contributor Author

SimranLahrani842 commented May 25, 2023

@SimranLahrani842 Please resolve the branch conflicts

Done sir kindly review and add the labels level3 and GSSoC'23 and merge the PR... @Arun9739

@Arun9739
Copy link
Contributor

@SimranLahrani842 LGTM

@SimranLahrani842
Copy link
Contributor Author

@SimranLahrani842 LGTM

@kunjgit please add the labels of level and gssoc and merge ..thanking you and @Arun9739

@kunjgit kunjgit added gssoc23 This tag is specifically used for GSSoC23 contributions level1 Documentation and small bug fixes in gssoc and removed Ready to merge 🥳 labels May 27, 2023
@kunjgit kunjgit merged commit c44e200 into kunjgit:main May 27, 2023
@kunjgit
Copy link
Owner

kunjgit commented May 27, 2023

Thank you @SimranLahrani842 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc23 This tag is specifically used for GSSoC23 contributions level1 Documentation and small bug fixes in gssoc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New game]: Tic Tac Toe

4 participants