chore(deps): upgrade better-sqlite3 to 13 - #1578
Closed
kunickiaj wants to merge 1 commit into
Closed
Conversation
This was referenced Sep 2, 2026
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kunickiaj
marked this pull request as ready for review
September 2, 2026 16:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
12 tasks
Owner
Author
|
Closing because better-sqlite3 13 fails the required clean-install E2E gate in node:24-bookworm-slim. Its install unconditionally invokes node-gyp and exits when Python is absent, despite bundled prebuilds; the current better-sqlite3 12 path works without adding build tools to runtime images. |
12 tasks
kunickiaj
added a commit
that referenced
this pull request
Sep 2, 2026
## Description Upgrade better-sqlite3 from 12.8.0 to 13.0.3 and align @types/better-sqlite3 at 9.6.0 across every Drizzle consumer. Version 13 moves to Node-API and bundles eight platform binaries instead of downloading a Node-version-specific prebuild during installation. pnpm 12.2.1 incorrectly synthesizes node-gyp rebuild despite the package declaring gypfile=false, so this change explicitly denies that unnecessary lifecycle and relies on the bundled binary for the documented x64/arm64 platform set. The install matrix records the concrete gains, compatibility limits, package-size increase, glibc floor, and runtime-failure behavior for unsupported targets. Supersedes #1578. ## Type of Change - [ ] 🚀 Feature (new functionality) - [ ] 🐛 Bug fix (fixes an issue) - [ ] 📚 Documentation (docs-only change) - [x] 🔧 Maintenance (refactor, chore, CI, etc.) - [ ] 🧪 Testing (test-only changes) ## Testing - [x] Relevant checks pass locally (`pnpm run tsc`, `pnpm run lint`, `pnpm run test`) - [ ] Added/updated tests for changes - [x] Manually verified changes work as expected Additional validation: - `pnpm run check` — 235 files, 5,745 tests passed; 3 todo - `pnpm run build` - `pnpm install --frozen-lockfile` - Cloudflare Worker node, integration, bundle, and dry-run checks - SQLite 3.53.4 runtime probes on Darwin arm64 - Clean Debian Bookworm glibc 2.36 installs and runtime probes on Linux x64 and arm64 - Alpine musl runtime probes with install scripts disabled on Linux x64 and arm64 - One Drizzle 0.45.2 instance and one @types/better-sqlite3 9.6.0 instance confirmed - Independent CodeReviewer: GO ## Checklist - [x] Code follows project style (`pnpm run lint` passes for touched files) - [x] Self-review completed - [x] Documentation updated (if needed) - [x] No new warnings introduced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade better-sqlite3 from 12.8.0 to 13.0.0 and align
@types/better-sqlite3at 9.6.0 across the workspace. Update the native-install decision document for v13 bundled prebuilds, SQLite 3.53.3, and the larger package footprint.Tracks
codemem-jnd6.7.3.Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Additional validation: Node 24.20.0 arm64 install and bundled-prebuild detection; in-memory database query using SQLite 3.53.3; 3,525 core tests; 473 viewer-server tests; Worker node and integration tests; package builds; Worker bundle dry-run; full
pnpm run check(5,740 tests); and high-severity Snyk scan with zero findings. Code review returned GO.Checklist
pnpm run lintpasses for touched files)