Updated subnet tags and tightened up the security groups #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+16
to
+32
| resource "aws_security_group" "ec2_instance" { | ||
| name = "IN-SG" | ||
| description = "Allow inbound and outbound traffic to EC2 instances from load balancer security group" | ||
| ingress { | ||
| from_port = 80 | ||
| to_port = 80 | ||
| protocol = "tcp" | ||
| security_groups = [aws_security_group.lb.id] | ||
| } | ||
| egress { | ||
| from_port = 0 | ||
| to_port = 0 | ||
| protocol = "-1" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
| vpc_id = aws_vpc.this.id | ||
| } |
Check failure
Code scanning / checkov
Ensure every security groups rule has a description Error
Comment on lines
+34
to
+50
| resource "aws_security_group" "lb" { | ||
| name = "LB-SG" | ||
| description = "Allow inbound and outbound traffic to load balancer from the internet." | ||
| ingress { | ||
| from_port = 80 | ||
| to_port = 80 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
| egress { | ||
| from_port = 0 | ||
| to_port = 0 | ||
| protocol = "-1" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
| vpc_id = aws_vpc.this.id | ||
| } |
Check failure
Code scanning / checkov
Ensure no security groups allow ingress from 0.0.0.0:0 to port 80 Error
Comment on lines
+34
to
+50
| resource "aws_security_group" "lb" { | ||
| name = "LB-SG" | ||
| description = "Allow inbound and outbound traffic to load balancer from the internet." | ||
| ingress { | ||
| from_port = 80 | ||
| to_port = 80 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
| egress { | ||
| from_port = 0 | ||
| to_port = 0 | ||
| protocol = "-1" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
| vpc_id = aws_vpc.this.id | ||
| } |
Check failure
Code scanning / checkov
Ensure every security groups rule has a description Error
|
💰 Infracost estimate: monthly cost will not change View in Infracost Cloud. This comment will be updated when the cost estimate changes. |
|
💰 Infracost estimate: monthly cost will not change View in Infracost Cloud. This comment will be updated when the cost estimate changes. |
Terraform Format and Style 🖌
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR close #17 and close #3