Skip to content

fix(bearings): expose full truncated board text - #2907

Open
parjmeneses wants to merge 9 commits into
kunchenguid:mainfrom
parjmeneses:fm/bearings-board-truncation-tooltips
Open

fix(bearings): expose full truncated board text#2907
parjmeneses wants to merge 9 commits into
kunchenguid:mainfrom
parjmeneses:fm/bearings-board-truncation-tooltips

Conversation

@parjmeneses

Copy link
Copy Markdown

Summary

  • expose exact full text through native titles for clipping-prone Bearings board content
  • retain visible labels, mobile wrapping, keyboard behavior, and Lavish interactions
  • add deterministic headless-free renderer regressions covering long and markup-like payloads

Validation

  • no-mistakes review completed after accepted tooltip decisions
  • targeted Bearings board tests passed, including real-browser visual verification
  • pinned ShellCheck 0.11.0 and actionlint 1.7.12 passed through bin/fm-lint.sh

The branch was pushed by no-mistakes through the authenticated fork. This PR is intentionally not merged.

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown

Confidence Score: 4/5

The PR should not merge until the landed PR-link tooltip implementation and its new deterministic assertion agree.

A valid landed item with a PR URL reaches an unchanged renderer branch that never sets title, while the newly added test requires that exact title and therefore fails.

Files Needing Attention: tests/fm-bearings-board.test.sh and .agents/skills/bearings/assets/board-template.html

Reviews (1): Last reviewed commit: "no-mistakes(lint): silence SC2016 on jq ..." | Re-trigger Greptile

grep -qF 'value \u003cmust stay text>' "$board" \
|| fail "the markup-like tooltip text was not \\u003c-escaped in the injected payload"
grep -qF 'value <must stay text>' "$board" \
&& fail "the built board embedded the markup-like tooltip text as live markup"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Landed PR tooltip assertion fails

When a landed item has a pr_url, the renderer creates .bb-row__pr without assigning its title, so this new assertion cannot find the full URL and the tooltip regression test fails deterministically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant