fix(bearings): expose full truncated board text - #2907
Open
parjmeneses wants to merge 9 commits into
Open
Conversation
Confidence Score: 4/5The PR should not merge until the landed PR-link tooltip implementation and its new deterministic assertion agree. A valid landed item with a PR URL reaches an unchanged renderer branch that never sets Files Needing Attention: tests/fm-bearings-board.test.sh and .agents/skills/bearings/assets/board-template.html Reviews (1): Last reviewed commit: "no-mistakes(lint): silence SC2016 on jq ..." | Re-trigger Greptile |
| grep -qF 'value \u003cmust stay text>' "$board" \ | ||
| || fail "the markup-like tooltip text was not \\u003c-escaped in the injected payload" | ||
| grep -qF 'value <must stay text>' "$board" \ | ||
| && fail "the built board embedded the markup-like tooltip text as live markup" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bin/fm-lint.shThe branch was pushed by no-mistakes through the authenticated fork. This PR is intentionally not merged.